update tox / CI config to more recent Python versions #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
commented
Oct 19, 2021
| @@ -12,7 +12,7 @@ commands = | |||
| python -m pytest --cov --capture=no --benchmark-skip {posargs:tests} | |||
|
|
|||
| [testenv:benchmark] | |||
| basepython = python3.7 | |||
There was a problem hiding this comment.
I don't know if these need to be Python 3.7, but it would be nice to at least make the envlist change.
terencehonles
force-pushed
the
update-tox-config
branch
from
60a6986
to
0a6e56d
Compare
terencehonles
changed the title
terencehonles
commented
Oct 19, 2021
| @@ -19,6 +22,6 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-python@v2 | |||
| with: | |||
| python-version: 3.7 | |||
There was a problem hiding this comment.
It doesn't seem like this file is actually being used, and I'm not sure this should be fixed with the config above.
|
#385 should probably be considered instead of this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.