Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core blocks: Extract edit to their own file - part 1 #6637

Merged
merged 2 commits into from
May 8, 2018
Merged

Core blocks: Extract edit to their own file - part 1 #6637

merged 2 commits into from
May 8, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 8, 2018 •
edited
Loading

Description

This PR follows the work started by @hypest in #5816 annd #6626 to have edit component in a separate file. This helps to speed up exploration how to make Gutenberg work with mobile apps using React Native implementation.

There are no changes in the logic. This PR contains only extract and move code refactoring.

How has this been tested?

Manually. The following blocks should still work as before:

  • Audio
  • Shared block
  • Button
  • Categories

Types of changes

Refactoring

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Feature] Blocks Overall functionality of blocks [Feature] Extensibility The ability to extend blocks or the editing experience labels May 8, 2018
@gziolo gziolo self-assigned this May 8, 2018
@gziolo gziolo requested a review from hypest May 8, 2018 09:38
@gziolo gziolo added this to the 2.9 milestone May 8, 2018
@gziolo gziolo requested a review from a team May 8, 2018 09:39
@hypest
Copy link
Contributor

hypest commented May 8, 2018

Added a commit (79f7e03) that extracts the edit function of the heading block.

@gziolo gziolo force-pushed the update/core-blocks-edit-1 branch from 79f7e03 to b25ba3d Compare May 8, 2018 13:07
hypest
hypest approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from the RN app side that I tested.

@gziolo gziolo merged commit c2a5189 into master May 8, 2018
@gziolo gziolo deleted the update/core-blocks-edit-1 branch May 8, 2018 13:43
@gziolo
Copy link
Member Author

gziolo commented May 8, 2018

I tested it locally and it all works properly with the existing blocks.

@gziolo gziolo mentioned this pull request May 8, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@gziolo gziolo

Labels
[Feature] Blocks Overall functionality of blocks [Feature] Extensibility The ability to extend blocks or the editing experience
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @hypest