Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core blocks: Refactor blocks to use edit file - part 2 #6641

Merged
merged 1 commit into from
May 9, 2018
Merged

Core blocks: Refactor blocks to use edit file - part 2 #6641

merged 1 commit into from
May 9, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 8, 2018

Description

This PR follows the work started by @hypest in #5816, #6626 and continued in #6637 by me, to have edit component in a separate file. This helps to speed up exploration how to make Gutenberg work with mobile apps using React Native implementation.

There are no changes in the logic. This PR contains only extract and move code refactoring.

How has this been tested?

Manually. The following blocks should still work as before:

  • Freeform
  • Gallery
  • Image
  • Latest Posts

Types of changes

Refactoring

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Feature] Blocks Overall functionality of blocks [Feature] Extensibility The ability to extend blocks or the editing experience labels May 8, 2018
@gziolo gziolo self-assigned this May 8, 2018
@gziolo gziolo requested a review from a team May 8, 2018 14:22
@gziolo gziolo added this to the 2.9 milestone May 8, 2018
noisysocks
noisysocks approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@noisysocks noisysocks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it—tested locally, it works 👍

@gziolo gziolo merged commit 823dcf2 into master May 9, 2018
@gziolo gziolo deleted the update/core-blocks-edit branch May 9, 2018 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

Assignees

@gziolo gziolo

Labels
[Feature] Blocks Overall functionality of blocks [Feature] Extensibility The ability to extend blocks or the editing experience
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @noisysocks