Patterns: Make theme pattern lock icons consistent with block toolbar's menu item #54234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
@jasmussen or @jameskoster can you confirm whether we do in fact want to make these lock icons more consistent? There are a couple of issues with this quick draft of a PR:
Do you think it is worth getting an equivalent to the |
|
Size Change: +15 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
|
I think the application of the lock icon could use a design audit. The outlined version was originally intended to represent a default/neutral/passive state, specifically for blocks (see: #39916 (comment)). Based on that, the current implementation on the Patterns grid is correct. But it may be worth revisiting how much value there is in having the two versions of the same icon (filled + outlined). It creates inconsistency, and I had to look up why the oultined version was added in the first place which suggests it may not be communicating it's purpose all that well. Perhaps it would be better to use |
I'm happy to shelve this PR if desired, until such a time as we deem it a priority.
Thanks, that does shed some light on it. |
|
I'll defer to Jay on this one! |
|
Thanks @jameskoster and @jasmussen for the feedback. Appreciate it 👍
Given the pattern grid is correct based on what's been said. I'll close this PR and related issue. We can easily revive it once any audit of the lock icons is completed and we have a clear goal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53285
What?
Updates the lock icons used in the site editor Patterns page, to match the lock outline icon used in block toolbar more menu's lock item.
Why?
Consistency is good.
See: #51948 (comment)
How?
Reuses the
lockOutlineicon however this PR also currently tweaks the rendered size of the icon so it is more inline with what was already there.Would it be better to have a
lockOutlineSmallicon as an equivalent to thelockSmallicon?Testing Instructions
Screenshots or screencast
Lock icon in block toolbar more menu:
