Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: Make lock icons more consistent between theme patterns in site editor and block toolbar's more menu #53285

Closed
aaronrobertshaw opened this issue Aug 3, 2023 · 1 comment
Closed

Patterns: Make lock icons more consistent between theme patterns in site editor and block toolbar's more menu #53285

aaronrobertshaw opened this issue Aug 3, 2023 · 1 comment
Assignees
@aaronrobertshaw
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@aaronrobertshaw
Copy link
Contributor

aaronrobertshaw commented Aug 3, 2023 •
edited
Loading

Make lock icons more consistent between theme patterns in site editor and block toolbar's more menu

See comments on earlier patterns issues: #51948 (comment) & #51771 (comment)
@aaronrobertshaw aaronrobertshaw converted this from a draft issue Aug 3, 2023
@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Aug 3, 2023
@aaronrobertshaw aaronrobertshaw changed the title Make lock icons more consistent between theme patterns in site editor and block toolbar's more menu Patterns: Make lock icons more consistent between theme patterns in site editor and block toolbar's more menu Aug 3, 2023
@aaronrobertshaw aaronrobertshaw self-assigned this Sep 7, 2023
@aaronrobertshaw aaronrobertshaw mentioned this issue Sep 7, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 7, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to In Progress in Patterns Sep 7, 2023
@aaronrobertshaw
Copy link
Contributor Author

The outlined version was originally intended to represent a default/neutral/passive state, specifically for blocks (see: #39916 (comment)).

Based on that, the current implementation on the Patterns grid is correct.

Making the lock icons consistent was explored in #54234 however it was revealed there that the current lock icon is by design. We may revisit whether it makes sense to have different lock icons in the future at which time we can reopen this. For the time being though, I'll close this issue.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Patterns Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Patterns
Status: Done
Milestone
No milestone
1 participant
@aaronrobertshaw