Patterns: update the Manage all my patterns command to redirect to site editor patterns list #52817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Feature] Patterns
glendaviesnz
added
[Type] Enhancement
92 tasks
|
Size Change: +665 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e4a799f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5617365791
|
Mamaduka
reviewed
Jul 21, 2023
aaronrobertshaw
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Thanks for iterating on this one 👍
Everything is testing as advertised and all the feedback is addressed.
My one question is whether we should be consolidating the "Manage all my patterns" and the "Open patterns" commands.
When filtering commands by "patterns", you see both, however, if your user doesn't have the capabilities to access the site editor or it's a non-block theme, you only get the "Sorry, you are not allowed to access this page" message when choosing "Open patterns".
Alternatively, if you do have a block theme and permissions, you're getting essentially a duplicate command option.
I don't think this has to be a blocker for this PR but is something we could address in a follow-up.
Do you have any thoughts on combining these commands @richtabor?
|
@aaronrobertshaw I just went ahead and removed the 
and is less confusing without this duplicate I think. I wonder though if to make it similar to the other commands we should rename the remaining command to |
I went ahead and renamed it - it matches other commands much better as @richtabor let us know if you have any opinions on this. |
glendaviesnz
added
[Feature] Patterns
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
Manage all my patternscommand to redirect the site editor patterns page when using a block-based theme.Why?
Fixes: #52491
How?
Checks for block based theme, or site editor context and redirects accordingly.
Testing Instructions
Manage all my patternscommand in site editor and post editor and make sure it redirects to the site editor patterns pageManage all my patternscommand in post editor make sure it redirects to the wp-admin patterns management pageauthorlevel user check that the command in the post editor redirects to wp-admin patterns page and not the site editorScreenshots or screencast
Block-based theme:
command-block.mp4
Non block theme:
command-non-block.mp4