[Core Commands]: Handle navigation commands based on access of site editor #52987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Type] Bug
ntsekouras
force-pushed
the
pass/options-to-core-commands
branch
from
56ca7c0 to
df307a2
Compare
|
Size Change: -2 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in df307a2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5670952023
|
|
Nice! This is a much cleaner approach, thanks for looking at this. Do we also want to make |
|
I don't see the reason why the |
Yeah, actually that makes much more sense. The low level package should be the |
ntsekouras
force-pushed
the
pass/options-to-core-commands
branch
from
fed7558 to
ea4c8fd
Compare
5 tasks
ntsekouras
changed the title
useCommands
mcsf
approved these changes
Jul 27, 2023
mikachan
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #52154
Related: #52817
Core Commandspackage loads some navigation commands that need different handling between a block theme and a classic one, and we need to take into account if the user has permissions to access the site editor. For this reason theblock-editordependency is added(also see here).Notes
We will need some reorganization(and addition of some extra logic) of the current navigation commands, because more commands navigate to the site editor interface(ex a link to page, etc..). This PR for now only adds conditionally the
useSiteEditorBasicNavigationCommandscommands.Test the following commands:
Testing Instructions