Framework: Upgrade Rememo dependency to 2.4.0 #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
|
I'm merging to update the other related PRs |
gziolo
reviewed
Feb 12, 2018
| @@ -155,6 +155,7 @@ function gutenberg_register_scripts_and_styles() { | |||
| gutenberg_get_script_polyfill( array( | |||
| '\'Promise\' in window' => 'promise', | |||
| '\'fetch\' in window' => 'fetch', | |||
| '\'WeakMap\' in window' => 'WeakMap', | |||
There was a problem hiding this comment.
I don't think we ever register WeakMap polyfill.
There was a problem hiding this comment.
Oh, whoops, I was used to my original implementation which had passed this through as a feature argument to polyfill.io . I'll see about fixing this up.
There was a problem hiding this comment.
Noting that this should not cause breakage for users without WeakMap support, as in later iterations of the new rememo release, it was made to be an optional enhancement.
There was a problem hiding this comment.
Nice, I guess we need those optimizations for WP community :D
This was referenced Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: aduth/rememo#1
Related: #4939
Related: #4955
This pull request seeks to upgrade the
rememodependency from 2.3.4 to 2.4.0 .View Changelog
Notably, the new version improves support for nested dependants, which is important for the
getBlockselector which otherwise has its cache busted much more frequently than desired, having performance impact on frequent block changes (such as those proposed in #4955).Testing instructions:
Verify that there are no regressions in the behavior of block changes.
Note that block changes should only incur rerenders to the relevant block†, e.g. using React Developer Tools Highlight Updates feature.
Ensure unit tests pass:
† There are still some unnecessary rerenders, though not nearly as bad as original in #4955 where every block would re-render.