Framework: Remove invalid reference to WeakMap polyfill #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5002 (comment)
This pull request seeks to remove a reference to a WeakMap polyfill which is both invalid and unnecessary. Earlier iterations of what resulted in the rememo 2.4.0 release required WeakMap, so a polyfill was added to our script enqueueing. This was later turned into a soft dependency, leveraging WeakMap if present as an optimization.
Further, this polyfill does not work, because it expects a script handle matching the value in the tests array, but this was never registered.
Testing instructions:
Verify there are no regressions in editor usage, particularly around memoized selectors (block manipulation).
For extra credit, test in a browser which doesn't support WeakMap (IE11).