Fix the upgrader_process_complete hook for wp_theme_has_theme_json

[oandregal]

Follow-up to #45543

What

This properly sets up the hook upgrader_process_complete, given it all the info it needs about.

Why

Without this, the upgrade process (translations, plugins, themes, core) will report a fatal in the logs (although it will proceed and complete).

How

Telling the hook the callback will receive two parameters (note the last parameter, it'll be 1 by default):

add_action( 'hook_name', 'callback', 10, 2 );

Test instructions

Verify the bug exists:

• Check out the 14.5.3 branch (it should also happen in trunk): git checkout -b 14.5.3 14.5.3.
• Go to a site.
• Downgrade any plugin you have to a previous version. I've used create-block-theme and the wp-cli: wp plugin update create-block-theme --version=1.3.7. See how to use the wp-cli with the bundled wp-env.
• Go to the plugins admin page and upgrade the plugin.
• The expected result is that it works as expected and no notices are shown. Instead, what happens is that the upgrade is completed, but a notice is shown in the screen. If you inspect the logs you'll see something like:

[18-Nov-2022 09:21:15 UTC] PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function _wp_theme_has_theme_json_clean_cache_upon_upgrading_active_theme(), 1 passed in /home/andre/flywheel-sites/wordpress-nightly/app/public/wp-includes/class-wp-hook.php on line 310 and exactly 2 expected in /home/andre/src/gutenberg/lib/compat/wordpress-6.2/get-global-styles-and-settings.php:67
Stack trace:
#0 /home/andre/flywheel-sites/wordpress-nightly/app/public/wp-includes/class-wp-hook.php(310): _wp_theme_has_theme_json_clean_cache_upon_upgrading_active_theme(Object(Plugin_Upgrader))
#1 /home/andre/flywheel-sites/wordpress-nightly/app/public/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters('', Array)
#2 /home/andre/flywheel-sites/wordpress-nightly/app/public/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#3 /home/andre/flywheel-sites/wordpress-nightly/app/public/wp-admin/includes/class-plugin-upgrader.php(371): do_action('upgrader_proces...', Object(Plugin_Upgrader), Array)
#4 /home/andre/flywheel-sites/wordpress-nightly/app/public in /home/andre/src/gutenberg/lib/compat/wordpress-6.2/get-global-styles-and-settings.php on line 67

Verify this PR fixes it:

• Reproduce the same instructions using this PR.
• Verify that there's no fatal errors reported (in the screen and the log).

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[mmtr]

Thanks for the speedy fix!

[oandregal]

We may want to create a 14.5.4 release with this fix. I'm unavailable to do it now, pinged folks privately to check availability. I'd appreciate if anyone else can help with this.