Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP GitHub checks failing since Gutenberg 14.5.3 release #278

Closed
Jinksi opened this issue Nov 18, 2022 · 2 comments
Closed

PHP GitHub checks failing since Gutenberg 14.5.3 release #278

Jinksi opened this issue Nov 18, 2022 · 2 comments
Labels
type: bug The issue is a confirmed bug. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@Jinksi
Copy link
Member

Jinksi commented Nov 18, 2022

Describe the bug

"PHP linting and tests" GitHub Actions in this repo are failing since the release of Gutenberg 14.5.3.

The following fatal error occurs during build environment setup (see example log):

Installing Gutenberg (14.5.3)
...
PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function _wp_theme_has_theme_json_clean_cache_upon_upgrading_active_theme(), 1 passed in /tmp/wordpress/wp-includes/class-wp-hook.php on line 310 and exactly 2 expected in /tmp/wordpress/wp-content/plugins/gutenberg/lib/compat/wordpress-6.2/get-global-styles-and-settings.php:67
...
wordpress/wp-content/plugins/gutenberg/lib/compat/wordpress-6.2/get-global-styles-and-settings.php on line 67

This error looks like it is related to changes included in the Gutenberg 14.5.3 release on Nov 18:

Update wp_theme_has_theme_json to use WP_Object_Cache. (https://github.com/WordPress/gutenberg/pull/45543)

image

To Reproduce

  1. View the list of "PHP linting and tests" GitHub Actions in this repo
  2. Notice that check tests since Nov 18 are failing
  3. View the details of one of these checks (e.g. this check that was previously passing)
  4. Notice the messages above in each log.
@Jinksi Jinksi added type: bug The issue is a confirmed bug. type: task The issue is an internally driven task (e.g. from another A8c team). labels Nov 18, 2022
@Jinksi Jinksi changed the title PHP GH checks failing since Gutenberg 14.5.3 release PHP GitHub checks failing since Gutenberg 14.5.3 release Nov 18, 2022
@Jinksi
Copy link
Member Author

Jinksi commented Nov 18, 2022

This has been noticed by the Gutenberg team and is being resolved in WordPress/gutenberg#45881

@Jinksi
Copy link
Member Author

Jinksi commented Nov 19, 2022

@Jinksi Jinksi closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

1 participant