-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update templateLock
value from noContent
to contentOnly
#44131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
September 13, 2022 16:05
oandregal
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
Sep 13, 2022
Size Change: +17 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bph
added
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Sep 14, 2022
ockham
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Sep 19, 2022
ockham
pushed a commit
that referenced
this pull request
Sep 19, 2022
I just cherry-picked this PR to the wp/6.1 branch to get it included in the next release: 81b5252 |
ockham
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Sep 19, 2022
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the
templateLock
s value callednoContent
bycontentOnly
.Why?
It aims to create more clarity about what it really does. See comment and original thread.
How?
By updating all the places in which
noContent
is used.Testing Instructions
Verify that it works as before.