Editor: Fix post lock data inconsistency #37914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
Mamaduka
added
[Package] Editor
|
Size Change: +2 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
@jasmussen, I think avatar margins could use some adjustment in this component. |
|
Very nice, this is what I see: I think we could remove the
We can also bump the right margin to $grid-unit-30 perhaps, but I'd appreciate @javierarce thoughts here, so we can get the metrics right: |
|
Instead of using heartbeat, it should great we use this new REST API that I worked on #37789 |
Thanks for working on that, @spacedmonkey. I will try to test/review this week. Meanwhile, I tried to keep things simple and fix the current inconsistency. |
|
@spacedmonkey, can we merge this as a short-term solution? |
spacedmonkey
approved these changes
Jan 17, 2022
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 5, 2022
Backporting fixes introduced in WordPress/gutenberg#37914. Props Mamaduka. Fixes #55238. Built from https://develop.svn.wordpress.org/trunk@53070 git-svn-id: http://core.svn.wordpress.org/trunk@52659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
Backported to WordPress core with https://core.trac.wordpress.org/changeset/53070. |
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Apr 5, 2022
Backporting fixes introduced in WordPress/gutenberg#37914. Props Mamaduka. Fixes #55238. Built from https://develop.svn.wordpress.org/trunk@53070 git-svn-id: https://core.svn.wordpress.org/trunk@52659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #37725.
PR fixed post lock data inconsistency between editor settings and heartbeat response. The editor settings were missing the user avatar and heartbeat user display name.
P.S. I will try to create a core patch later this week.
How has this been tested?
Create two admin user accounts. Save a post as one user, then log in as the other user in an incognito mode and load the same post.
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).