Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show user's name when a post is being taken over #26648

Closed
wants to merge 1 commit into from
Closed

Show user's name when a post is being taken over #26648

wants to merge 1 commit into from

Conversation

oddevan
Copy link

@oddevan oddevan commented Nov 3, 2020 •
edited
Loading

Description

Use the text property returned by the heartbeat API to show the name of the user taking over a post. See #26645

How has this been tested?

Tested code change in my local running WordPress 5.3

Screenshots

Previous behavior:

Screen Shot 2020-11-02 at 7 58 59 PM

After fix:

Screen Shot 2020-11-02 at 8 40 03 PM

Types of changes

Bug Fix - the name property is never given by the Heartbeat API; this uses the text property instead.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@talldan talldan linked an issue Nov 3, 2020 that may be closed by this pull request
Name missing when taking over post #26645
Closed
@talldan talldan added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Nov 3, 2020
@elliott-stocks
Copy link

Experiencing the same issue in 5.6. Do we know which release this is planned for, @adamsilverstein ?

Base automatically changed from master to trunk March 1, 2021 15:44
@Mamaduka
Copy link
Member

Thanks for contributing, @oddevan!

I didn't know this PR existed, but the issue was fixed in #37914 and should be part of the WP 6.0 release.

I'm going to close this PR.

@Mamaduka Mamaduka closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name missing when taking over post
4 participants
@oddevan @elliott-stocks @Mamaduka @talldan