Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide parent selector in widget area #26011

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Hide parent selector in widget area #26011

merged 3 commits into from
Oct 15, 2020

Conversation

kevin940726
Copy link
Member

@kevin940726 kevin940726 commented Oct 12, 2020 •
edited
Loading

Description

Fix #25908.

Introduced a new block meta data: hideParentSelector, to indicate if the block parent selector should show or not. Not sure if it's the optimal solution?

How has this been tested?

  1. Go to Widgets screen
  2. Select any legacy widget
  3. Hover over the parent selector in the block toolbar
  4. Observe that the parent selector isn't showing

Screenshots

image

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@kevin940726 kevin940726 added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 12, 2020
@kevin940726 kevin940726 marked this pull request as draft October 12, 2020 04:55
@kevin940726 kevin940726 force-pushed the update/hide-parent-selector-in-widget-area branch from 2f55199 to 3620831 Compare October 12, 2020 05:02
@kevin940726 kevin940726 marked this pull request as ready for review October 12, 2020 05:04
@kevin940726 kevin940726 force-pushed the update/hide-parent-selector-in-widget-area branch from 3620831 to 35b7367 Compare October 12, 2020 05:05
@github-actions
Copy link

github-actions bot commented Oct 12, 2020 •
edited
Loading

Size Change: +46 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/block-editor/index.js 130 kB +35 B (0%)
build/edit-widgets/index.js 21.3 kB +11 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.6 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/index.js 143 kB 0 B
build/block-library/style-rtl.css 7.71 kB 0 B
build/block-library/style.css 7.71 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/index.js 169 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12.1 kB 0 B
build/data-controls/index.js 684 B 0 B
build/data/index.js 8.63 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.3 kB 0 B
build/edit-post/style.css 6.29 kB 0 B
build/edit-site/index.js 21.3 kB 0 B
build/edit-site/style-rtl.css 3.86 kB 0 B
build/edit-site/style.css 3.86 kB 0 B
build/edit-widgets/style-rtl.css 2.97 kB 0 B
build/edit-widgets/style.css 2.97 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 42.5 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.04 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.07 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

draganescu
draganescu approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix. It may be we'll meet more situations where this should be hidden.

talldan
talldan approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Might need to rebase to take into account the PHP tests fix #26079.

@kevin940726 kevin940726 force-pushed the update/hide-parent-selector-in-widget-area branch from 3075c84 to 9df611c Compare October 14, 2020 08:10
@kevin940726 kevin940726 force-pushed the update/hide-parent-selector-in-widget-area branch from 9df611c to 8645666 Compare October 14, 2020 10:18
@talldan talldan merged commit 0f978d2 into master Oct 15, 2020
@talldan talldan deleted the update/hide-parent-selector-in-widget-area branch October 15, 2020 05:39
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 15, 2020
@talldan talldan mentioned this pull request Oct 19, 2020
Closed
@jsnajdr jsnajdr mentioned this pull request Jan 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@draganescu draganescu draganescu approved these changes

@adamziel adamziel Awaiting requested review from adamziel

@noisysocks noisysocks Awaiting requested review from noisysocks

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@ellatrix ellatrix Awaiting requested review from ellatrix

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 9.2
Development

Successfully merging this pull request may close these issues.

Widget Editor: Select parent (widget area) should not exist
3 participants
@kevin940726 @draganescu @talldan