Fix bad var name in BlockParentSelector #28325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Jan 19, 2021
ellatrix
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a typo in the
useSelectcallback of theBlockParentSelector. Simplified, the code does something like:Note how the
returnstatement uses the variable in the outer scope instead of the inner one with the_prefix. When ES6let/constis used, this code crashes with:But after transpiled by Babel to
var, access before initialization becomes OK and theparentBlockTypevalue is simplyundefined. ThehasBlockSupportcall then has parameters:and the result should be always
true(the third param specifies the default) and thenshouldHideis alwaysfalse.@kevin940726 According to what I write above, the parent selector hiding feature from #26011 should be broken? Can you help me verify that?
It's also possible that further minification of the compiled code changes the
undefinedvalue to something else again.I discovered this bug after disabling most Babel transforms in a local build. The goal was to get better debugging of untranspiled
yieldorawaitstatements.