Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sidebars endpoint] Add permissions PHPUnit tests #24784

Merged
merged 10 commits into from
Aug 26, 2020
+145 −13
Merged

[Sidebars endpoint] Add permissions PHPUnit tests #24784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec26a42
Add PHPUnit tests for users who don't have permissions to interact wi…
adamziel Aug 25, 2020
a44b6ad
Lint
adamziel Aug 25, 2020
ab27615
Update phpunit/class-rest-sidebars-controller-test.php
adamziel Aug 26, 2020
0bcfa40
Update phpunit/class-rest-sidebars-controller-test.php
adamziel Aug 26, 2020
1a3de5d
Update phpunit/class-rest-sidebars-controller-test.php
adamziel Aug 26, 2020
87af916
Update phpunit/class-rest-sidebars-controller-test.php
adamziel Aug 26, 2020
cce8037
Update phpunit/class-rest-sidebars-controller-test.php
adamziel Aug 26, 2020
af8295f
Enable experiment in bootstrap.php
adamziel Aug 26, 2020
14e6568
Merge branch 'update/phpunit-widget-screen' of github.com:WordPress/g…
adamziel Aug 26, 2020
ae281c5
Address feedback
adamziel Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions phpunit/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,15 @@ function fail_if_died( $message ) {
}
tests_add_filter( 'wp_die_handler', 'fail_if_died' );

$GLOBALS['wp_tests_options'] = array(
'gutenberg-experiments' => array(
'gutenberg-widget-experiments' => '1',
),
);

// Start up the WP testing environment.
require $_tests_dir . '/includes/bootstrap.php';

// Use existing behavior for wp_die during actual test execution.
remove_filter( 'wp_die_handler', 'fail_if_died' );

151 changes: 138 additions & 13 deletions phpunit/class-rest-sidebars-controller-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,12 @@ class REST_Sidebars_Controller_Test extends WP_Test_REST_Controller_Testcase {
/**
* @var int
*/
protected static $per_page = 50;
protected static $author_id;

/**
* REST_Sidebars_Controller_Test constructor.
* @var int
*/
public function __construct() {
parent::__construct();
require_once dirname( __FILE__ ) . '/../lib/class-wp-rest-sidebars-controller.php';
add_filter(
'rest_api_init',
function () {
$sidebars = new WP_REST_Sidebars_Controller();
$sidebars->register_routes();
}
);
}
protected static $per_page = 50;

/**
* Create fake data before our tests run.
Expand All @@ -68,6 +58,11 @@ public static function wpSetUpBeforeClass( $factory ) {
'role' => 'editor',
)
);
self::$author_id = $factory->user->create(
array(
'role' => 'author',
)
);
self::$subscriber_id = $factory->user->create(
array(
'role' => 'subscriber',
Expand Down Expand Up @@ -152,6 +147,36 @@ public function test_get_items() {
$this->assertEquals( array(), $data );
}

/**
*
*/
public function test_get_items_no_permission() {
wp_set_current_user( 0 );
$request = new WP_REST_Request( 'GET', '/__experimental/sidebars' );
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 401 );
}

/**
*
*/
public function test_get_items_wrong_permission_author() {
wp_set_current_user( self::$author_id );
$request = new WP_REST_Request( 'GET', '/__experimental/sidebars' );
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 403 );
}

/**
*
*/
public function test_get_items_wrong_permission_subscriber() {
wp_set_current_user( self::$subscriber_id );
$request = new WP_REST_Request( 'GET', '/__experimental/sidebars' );
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 403 );
}

/**
*
*/
Expand Down Expand Up @@ -274,6 +299,57 @@ public function test_get_item() {
);
}

/**
*
*/
public function test_get_item_no_permission() {
wp_set_current_user( 0 );
$this->setup_sidebar(
'sidebar-1',
array(
'name' => 'Test sidebar',
)
);

$request = new WP_REST_Request( 'GET', '/__experimental/sidebars/sidebar-1' );
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 401 );
adamziel marked this conversation as resolved.
Show resolved Hide resolved
}

/**
*
*/
public function test_get_item_wrong_permission_author() {
wp_set_current_user( self::$author_id );
$this->setup_sidebar(
'sidebar-1',
array(
'name' => 'Test sidebar',
)
);

$request = new WP_REST_Request( 'GET', '/__experimental/sidebars/sidebar-1' );
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 403 );
}

/**
*
*/
public function test_get_item_wrong_permission_subscriber() {
wp_set_current_user( self::$subscriber_id );
$this->setup_sidebar(
'sidebar-1',
array(
'name' => 'Test sidebar',
)
);

$request = new WP_REST_Request( 'GET', '/__experimental/sidebars/sidebar-1' );
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 403 );
}

/**
* The test_update_item() method does not exist for sidebar.
*/
Expand Down Expand Up @@ -378,6 +454,54 @@ public function test_update_item() {
);
}

/**
*
*/
public function test_update_item_no_permission() {
wp_set_current_user( 0 );

$request = new WP_REST_Request( 'POST', '/__experimental/sidebars/sidebar-1' );
$request->set_body_params(
array(
'widgets' => array(),
)
);
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 401 );
adamziel marked this conversation as resolved.
Show resolved Hide resolved
}

/**
*
*/
public function test_update_item_wrong_permission_author() {
wp_set_current_user( self::$author_id );

$request = new WP_REST_Request( 'POST', '/__experimental/sidebars/sidebar-1' );
$request->set_body_params(
array(
'widgets' => array(),
)
);
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 403 );
}

/**
*
*/
public function test_update_item_wrong_permission_subscriber() {
wp_set_current_user( self::$subscriber_id );

$request = new WP_REST_Request( 'POST', '/__experimental/sidebars/sidebar-1' );
$request->set_body_params(
array(
'widgets' => array(),
)
);
$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'widgets_cannot_access', $response, 403 );
}

/**
* The test_delete_item() method does not exist for sidebar.
*/
Expand Down Expand Up @@ -407,4 +531,5 @@ public function test_get_item_schema() {
$this->assertArrayHasKey( 'status', $properties );
$this->assertArrayHasKey( 'widgets', $properties );
}

}