[Sidebars endpoint] Add permissions PHPUnit tests #24784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the sidebars endpoint
adamziel
added
[Feature] Widgets Screen
|
Size Change: +2.43 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
20 tasks
draganescu
approved these changes
Aug 25, 2020
TimothyBJacobs
requested changes
Aug 25, 2020
| @@ -6,6 +6,15 @@ | |||
| * @subpackage REST_API | |||
| */ | |||
|
|
|||
| require_once dirname( __FILE__ ) . '/../lib/class-wp-rest-sidebars-controller.php'; | |||
| add_filter( | |||
There was a problem hiding this comment.
Suggested change
| add_filter( | |
| add_action( |
There was a problem hiding this comment.
Also, why do we need to include this here at all? If it is because the endpoint is in an experiment, I think we should do the same thing we did as the block directory and enable the experiment in the tests
tellyworth@26363cf#diff-85d18a6eb126c0f8c8da280e74555a2c
In phpunit/bootstrap.php.
$GLOBALS['wp_tests_options'] = array(
'gutenberg-experiments' => array(
'gutenberg-block-directory' => '1',
),
);| @@ -407,4 +457,11 @@ public function test_get_item_schema() { | |||
| $this->assertArrayHasKey( 'status', $properties ); | |||
| $this->assertArrayHasKey( 'widgets', $properties ); | |||
| } | |||
|
|
|||
| public function users_without_permissions() { | |||
There was a problem hiding this comment.
Are you sure this is working as expected? As far as I know, data providers are executed before setup before class, which means that the ids haven't been created yet. This is probably why the tests are passing when checking for a 401.
Co-authored-by: Timothy Jacobs <[email protected]>
Co-authored-by: Timothy Jacobs <[email protected]>
Co-authored-by: Timothy Jacobs <[email protected]>
Co-authored-by: Timothy Jacobs <[email protected]>
Co-authored-by: Timothy Jacobs <[email protected]>
…utenberg into update/phpunit-widget-screen
|
All good notes @TimothyBJacobs, I just addressed your comments, would you mind re-reviewing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds coverage for when the user is logged out or has insufficient permissions as per #24290 (review).
How has this been tested?
Confirm all checks pass on this PR.
Types of changes
Non-breaking change
Checklist: