-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Reakit to version 1.1.0 #23236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it's great to see everything promoted to stable :)
Let's wait for Travis to make the final call. It's moody today so it might block things a bit.
Size Change: +188 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
I haven't tested as I missed the details in the description that I see now 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me! Tested locally, and the Toolbar works as expected. Keyboard navigation works. Drilling in/out of dropdowns work. No errors/warnings being thrown in console (related to Reakit)
Thank you @diegohaz !
This fixes the warning reported by @noahtallen on #17355 (comment). It has been fixed on ariakit/ariakit#672.
Also, the
Composite
module is now stable, so I removed theunstable_
prefix from our code.Changelog
1.1.0 (2020-06-17)
Features
Input
component (#671) (79d3926), closes #665unstable_sort
method touseCompositeState
(57e409e)Composite
as stable (#667) (5e01f4c)1.0.5 (2020-06-17)
Bug Fixes
Composite
state update on unmounted components (#672) (1b1c9aa), closes #650How to test