Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide custom font size label and option from font size picker select #18049

Closed
wants to merge 1 commit into from
Closed

Hide custom font size label and option from font size picker select #18049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/components/src/font-size-picker/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ function getSelectValueFromFontSize( fontSizes, value ) {
return 'normal';
}

function getSelectOptions( optionsArray ) {
function getSelectOptions( optionsArray, disableCustomFontSizes ) {
if(disableCustomFontSizes){
return [
...optionsArray.map( ( option ) => ( { value: option.slug, label: option.name } ) )
];
}
return [
...optionsArray.map( ( option ) => ( { value: option.slug, label: option.name } ) ),
{ value: 'custom', label: __( 'Custom' ) },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you guard this line with the check instead or conditionally push to the object for the custom option to avoid code duplication?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i can try that.

Expand Down Expand Up @@ -72,7 +77,7 @@ function FontSizePicker( {
hideLabelFromVision={ true }
value={ currentSelectValue }
onChange={ onSelectChangeValue }
options={ getSelectOptions( fontSizes ) }
options={ getSelectOptions( fontSizes, disableCustomFontSizes ) }
/>
}
{ ( ! withSlider && ! disableCustomFontSizes ) &&
Expand Down