Hide custom font size label and option from font size picker select #18049

Waqas-Ali-Azhar · 2019-10-21T14:26:42Z

Description

This PR solves removes Custom as an option from font-size-picker, a fully accessible and customizable select component with font sizes, in the @wordpress/components package.

It works well, if you call function add_theme_support('disable-custom-font-sizes') inside functions.php of the active theme, it hides custom size option inside font size picker select component on gutenberg paragraph block on post or page add or edit screens.

How has this been tested?

Blank installation of WP 5.2.3 and TwentyNineteen theme.
Install and enable Gutenberg forked from WordPress/gutenberg
Added patch
Run npm install, npm run-script build on command line inside gutenberg plugin folder
Goto post add screen and add a paragraph block
Add or remove add_theme_support('disable-custom-font-sizes') in functions.php of active theme
Custom font size option will be removed or shown respectively
Tested on post, page add new and edit menus, updated successfully

Screenshots

Types of changes

Bug fix ( Disabling custom font sizes does not remove 'custom' option from Paragraph block font size dropdown )

Checklist:

My code is tested.
[] My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.

Waqas-Ali-Azhar · 2019-10-28T10:17:07Z

Do, I need to change anything in my commit ? I see eslint & javascript mobile test is failed, can anyone guide ?

brentswisher · 2019-10-28T22:13:19Z

@Waqas-Ali-Azhar Thank you for your contribution! It's always exciting to see someone starting to contribute to WordPress.

It does look like there are some minor linting issues that need to be fixed in the PR. For any of the reports, you can click on "Details" for more information and then click on the name of the failing test (In this case, job 42766.1 Lint) for the specifics.

The other failing test "javascript mobile" can likely be ignored if the things that are failing are not related to the changes you made, which looks like the case here.

To make your life easier, instead of making the changes and submitting them back and waiting for Travis to run the lint test, you can run npm run lint before you commit changes and it will lint everything locally and tell you if there are any problems.

The linting rules are usually fairly self-explanatory, but the coding standards can help with any question: https://github.com/WordPress/gutenberg/blob/master/docs/contributors/coding-guidelines.md.

Also, please feel free to ask here if anything is still unclear, I'm happy to help!

Waqas-Ali-Azhar · 2019-10-28T22:19:42Z

Thank you @brentswisher i am very excited for this one to be merged as its my first PR and first one for Hacktoberfest. So to be merged my next step is to run lint command locally and resolve the issue and generate a new PR ?

brentswisher · 2019-10-28T22:34:02Z

@Waqas-Ali-Azhar That's awesome, Hacktoberfest is great!

To fix the linting issues, you will want to check out the branch you created for this PR, fix the issues and verify them with npm run lint. Then you can commit them and push the updates to your forked repository. Once the changes are seen by Github in your repository it will automatically update this PR so you don't need to open another one.

gziolo · 2019-10-31T15:55:16Z

packages/components/src/font-size-picker/index.js

+		return [
+			...optionsArray.map( ( option ) => ( { value: option.slug, label: option.name } ) )
+		];
+	}
 	return [
 		...optionsArray.map( ( option ) => ( { value: option.slug, label: option.name } ) ),
 		{ value: 'custom', label: __( 'Custom' ) },


Can you guard this line with the check instead or conditionally push to the object for the custom option to avoid code duplication?

Yes, i can try that.

brentswisher · 2019-11-13T14:41:02Z

Hey @Waqas-Ali-Azhar, just thought I would check in with you and see how it's going, is there anything I can help you with, or any questions you might have?

Waqas-Ali-Azhar · 2019-11-19T07:29:34Z

Hey @Waqas-Ali-Azhar, just thought I would check in with you and see how it's going, is there anything I can help you with, or any questions you might have?

Hey @brentswisher thanks for checking on me. I appreciate and definitely will use your guidance along the way to open source contributions, I was figuring out how to use guard and prevent code duplication, i think i have come up with a solution using const and return it, i will share code shortly and contribute in this week a new PR

brentswisher · 2019-12-02T15:34:55Z

Sounds great! Don't be afraid to push something up even if it isn't perfect, I'm happy to take a look and help move it forward.

brentswisher · 2020-02-05T15:00:56Z

Hey @Waqas-Ali-Azhar, just checking in, is this something you think you will be able to update? Any questions/concerns I can help with?

Waqas-Ali-Azhar · 2020-03-29T06:02:35Z

Just coming back to it again i did a fix could not submit that, can i share code here before submission ?

brentswisher · 2020-04-08T12:33:50Z

@Waqas-Ali-Azhar I'd be happy to try and help however I can, but it really is a lot easier if you can update your branch and re-push the changes, what was the reason you couldn't submit it? It's been long enough that your branch is probably a little out of date, you can try the instructions here for keeping your fork up to date which might help

Waqas-Ali-Azhar · 2020-04-08T13:20:55Z

Yeah i tried last week but there there was some ces issue coming there the dropdown control shrinks and text box expands. Let me see the work around and i will push it up. Thank You for utter support Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Brent Swisher <[email protected]> Sent: Wednesday, April 8, 2020 5:34:05 PM To: WordPress/gutenberg <[email protected]> Cc: Waqas Ali Azhar <[email protected]>; Mention <[email protected]> Subject: Re: [WordPress/gutenberg] Hide custom font size label and option from font size picker select (#18049) @Waqas-Ali-Azhar<https://github.com/Waqas-Ali-Azhar> I'd be happy to try and help however I can, but it really is a lot easier if you can update your branch and re-push the changes, what was the reason you couldn't submit it? It's been long enough that your branch is probably a little out of date, you can try the instructions here for keeping your fork up to date<https://github.com/WordPress/gutenberg/blob/master/docs/contributors/git-workflow.md> which might help — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#18049 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACZDKSX4MP5WL5BBDODTUBLRLRVL3ANCNFSM4JC6DGPA>.

Waqas-Ali-Azhar · 2020-08-31T10:26:35Z

@brentswisher i would be happy if you can help me, i lost my hardrive which contained all code, now it looks that main repository is a way ahead of time i forked it, can you put me to direction what i need to continue this pull request and clean my code please

Waqas-Ali-Azhar · 2020-09-03T07:51:30Z

@Waqas-Ali-Azhar I'd be happy to try and help however I can, but it really is a lot easier if you can update your branch and re-push the changes, what was the reason you couldn't submit it? It's been long enough that your branch is probably a little out of date, you can try the instructions here for keeping your fork up to date which might help

thanks it will definitely help

Waqas-Ali-Azhar · 2020-10-17T09:24:40Z

I upgraded my local branch via upstream and tried activating plugin in WordPress 5.5.1 , it says
and WordPres 5.2.3 does not meet gutenberg requirements anymore. I am looking to submit my first pull request, please guide

paaljoachim · 2021-05-21T21:59:07Z

@brentswisher and @Waqas-Ali-Azhar how is the PR coming along?
It would be great with a status update.

I noticed the last comment mentioned an error. Has this been taken care of? How can we help move the PR forward. Is the PR still valid? @aristath Perhaps this is a PR for you to check on?

mkaz · 2021-05-21T22:09:00Z

Reviewed in today's triage and it looks like this feature was added in #18842 so I'm going to close this PR.

@Waqas-Ali-Azhar thanks for the contribution, unfortunately this PR got stuck before being merged. Please do look for an additional issues and I also would be glad to help you.

Hide custom font size label and option from font size picker select

fcd15ea

Waqas-Ali-Azhar requested review from ajitbohra, chrisvanpatten, jorgefilipecosta, talldan and youknowriad as code owners October 21, 2019 14:26

Waqas-Ali-Azhar mentioned this pull request Oct 21, 2019

Disabling custom font sizes does not remove 'custom' option from Paragraph block font size dropdown #17941

Closed

youknowriad added [Type] Bug An existing feature does not function as intended Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Oct 22, 2019

talldan added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 24, 2019

brentswisher mentioned this pull request Oct 28, 2019

Add FontSizePicker component to Storybook #18149

Merged

brentswisher mentioned this pull request Oct 31, 2019

Font Size Picker: disableCustomFontSizes doesn't remove Custom option from the select box #18212

Closed

gziolo added [Package] Components /packages/components Storybook Storybook and its stories for components labels Oct 31, 2019

gziolo reviewed Oct 31, 2019

View reviewed changes

Soean removed the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Feb 19, 2020

Base automatically changed from master to trunk March 1, 2021 15:42

mkaz closed this May 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide custom font size label and option from font size picker select #18049

Hide custom font size label and option from font size picker select #18049

Waqas-Ali-Azhar commented Oct 21, 2019 •

edited by talldan

Loading

Waqas-Ali-Azhar commented Oct 28, 2019

brentswisher commented Oct 28, 2019

Waqas-Ali-Azhar commented Oct 28, 2019

brentswisher commented Oct 28, 2019

gziolo Oct 31, 2019

Waqas-Ali-Azhar Nov 1, 2019

brentswisher commented Nov 13, 2019

Waqas-Ali-Azhar commented Nov 19, 2019

brentswisher commented Dec 2, 2019

brentswisher commented Feb 5, 2020

Waqas-Ali-Azhar commented Mar 29, 2020

brentswisher commented Apr 8, 2020 •

edited

Loading

Waqas-Ali-Azhar commented Apr 8, 2020 via email

Waqas-Ali-Azhar commented Aug 31, 2020

Waqas-Ali-Azhar commented Sep 3, 2020

Waqas-Ali-Azhar commented Oct 17, 2020

paaljoachim commented May 21, 2021 •

edited

Loading

mkaz commented May 21, 2021

Hide custom font size label and option from font size picker select #18049

Hide custom font size label and option from font size picker select #18049

Conversation

Waqas-Ali-Azhar commented Oct 21, 2019 • edited by talldan Loading

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

Waqas-Ali-Azhar commented Oct 28, 2019

brentswisher commented Oct 28, 2019

Waqas-Ali-Azhar commented Oct 28, 2019

brentswisher commented Oct 28, 2019

gziolo Oct 31, 2019

Choose a reason for hiding this comment

Waqas-Ali-Azhar Nov 1, 2019

Choose a reason for hiding this comment

brentswisher commented Nov 13, 2019

Waqas-Ali-Azhar commented Nov 19, 2019

brentswisher commented Dec 2, 2019

brentswisher commented Feb 5, 2020

Waqas-Ali-Azhar commented Mar 29, 2020

brentswisher commented Apr 8, 2020 • edited Loading

Waqas-Ali-Azhar commented Apr 8, 2020 via email

Waqas-Ali-Azhar commented Aug 31, 2020

Waqas-Ali-Azhar commented Sep 3, 2020

Waqas-Ali-Azhar commented Oct 17, 2020

paaljoachim commented May 21, 2021 • edited Loading

mkaz commented May 21, 2021

Waqas-Ali-Azhar commented Oct 21, 2019 •

edited by talldan

Loading

brentswisher commented Apr 8, 2020 •

edited

Loading

paaljoachim commented May 21, 2021 •

edited

Loading