-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget Editor: Design Updates #24561
Comments
Love the exploration here, but just noting that we have 9 weeks until the feature freeze for WP 5.6, so any big changes here need to be done quickly or punted. |
Great job, Mark! Having it as close as possible to the standard method of adding blocks in Gutenberg would be best as I see it so that we can keep a consistent method of adding a block (widget). That would mean either opening the inserter as a sidebar or having the + inserter icon directly in a paragraph block. There could be as you mention an inactive area. So the user can drag blocks/widgets that one is not certain of using. My suggestion would be to actually test out both methods. Using the inserter that opens as a sidebar and the inserter inside the paragraph block (user can choose which method to use). Today we already have the widget experimental screen inside Gutenberg -> Experiments. So this would actually be something that can quickly get in place so we can get some testing done. With feedback we can refine the experience. |
I may be wrong, but in the mockups / GIFs above I don't see controls to move / rearrange the widgets by using a keyboard. In the current admin screen, this functionality is available in the "accessibility mode". |
Great point! The same accessible keyboard interactions found in the block editor would be adopted here as well. |
Based the feedback I've received, I've narrowed down the UX direction. Single widget areaShow only a single widget area at a time. Widget area switcherThere is a widget area switcher in the topbar that allows the user to jump to other widget areas. Widgets in the InserterWidgets have their own category in the Inserter panel.
Moving widgets to other areas
PrototypeThis is how it all comes together. Figma file. |
Displaying legacy widgets in the inserter is a great idea.
How would this look? Would it say "Activate in ... Inactive Widgets"? |
@noisysocks, I have that outlined here: #24698. I wrote it as "Move to Inactive Widgets" |
It's not a small mock-up, but I like it a lot. It does bring in a lot of new things:
Some of the stuff already exists, the question being if we can simply use them or will we find they're missing bits to enable this workflow. I am optimistic as it looks a lot like the flows the site editor mock-ups show. |
@mapk @paaljoachim the "All widget areas" screen is interesting but it kinda complicates things (a lot? cc @adamziel) Probably that listing is easier, but a new screen to support? |
A perspective. User enters the widget screen and sees the available widgets and widget areas. EDIT: EDIT: New widget screen has a similarity with the existing widgets screen. If a user uses the Classic Editor plugin the new Widget screen should work nicely even though they are not using Gutenberg. Full Site Editing in relation to the Widgets screen. Single view widget page.
Multi view widget page.
I do have a feeling that there is something I am not aware of affecting the way forward. Edit 2. |
While I see the conversation on the ideal design is still going on, it is important to point out a very important thing for accessibility: Whatever the final design will be, all admin pages need a good headings hierarchy:
I see that some of the mockups above just reuse the edit post page design, which has a top toolbar and no visible main H1. At the time of the discussion around the Gutenberg edit post page, this was discussed at length and the accessibility team accepted a visually hidden H1 as a compromise between design and accessibility needs. In a way, the accessibility team considered that decision an "exception". I'm not sure the accessibility need would agree in re-using a visually hidden H1 as default pattern for the new admin pages. Visible headings benefit all users. To me, it's of fundamental importance that any admin page clearly communicates what its about with a main H1. Headings also allow easy content navigation, both visually, and with assistive technology. I'll bring this point to the next weekly accessibility meeting for broader discussion. In the meantime, I'd like to kindly ask to review the proposed mockups and add visible headings, including a visible main H1. This is even more important as I'm seeing the layout above being proposed as the "default" new look of all the new admin pages (menus, etc.) |
Regarding the "widget area switcher in the topbar": I see that the visible text represent the state and not the available action. Still unclear to me what this control will actually be when implemented:
|
Yes, @draganescu, it would be a new screen. But it would align with all the other list view screens in wp-admin (ie. posts, pages, comments). The hesitation I have about showing all widget areas in the Editor at one time is that it eliminates the need for individual widget areas and doesn't jive smoothly with showing one editor at a time. I'd like to get more feedback on that. |
Personally I'd prefer the dropdown option as it's quicker. Going to an intermediary list screen requires a page load. |
A few thoughts on the current progress:
Also worth considering on very large viewports to stack widget areas horizontally.
The active block area should have some indication. Also the inserter shows a blue line when focusing / hovering a block to indicate insertion point. |
Here's a first prototype of open-by-default global inserter: #24822 |
Taking in the feedback from @mtias, here's another prototype. Multiple widget areas on screenEvery widget area the theme provides will be displayed on screen. Display the page titleAs noted by the accessibility team, we should continue to display the page title an an Widgets are at the bottom of the inserter panelAlthough the prototype doesn't really show this, it alludes to it. Widgets would reside at the bottom of the Inserter panel without disrupting the order of the Inserter categories. 3rd party widgets as block variationsThe Legacy Widget block will work much like the Embed block. A container block that displays 3rd party widgets as a block variation. I'm still working through how the block's description should read. If the block still reveals itself as a Legacy Widget block as what I believe is being suggested here, than should the widget name be included on the same line as I have it in the prototype, or on it's own line? Or in the block toolbar? Drag and drop between areasShowing all areas on screen allows us to keep the drag and drop interaction between areas. Notice that when a block is dropped in a new area, that area is identified in the Document Inspector. Inserter panelInserter panel is open by default, but can close and reopen as needed. This continues in alignment with #24822 Which area is active?We need a way to identify which area a block will be dropped into when adding from the Inserter panel. If no block is selected, but the area is active, that area is outlined in blue in the prototype. If a block is focused, the block is blue and the system knows to just add the block below the focused block. PrototypeHere's how it all comes together. |
@mapk to clarify, we already have a "widgets" category that holds blocks and many of the core widgets we ported to native blocks. I'd expect we would just register these to that same category. This category shows above Embeds. |
Thanks for adding the page title H1. I may not be updated on the latest designs but I see a difference between the H1+top toolbar design for this Widgets page: and the one proposed for the Navigation page in #24875 I guess exploring the same design for both pages is already in the works? Since these new pages will also set the new standard for all the new admin pages, I think consistency is key. |
Just for clarification, I don't think either of these pages are setting any standards for new admin pages. The focus is to bring in blocks without degrading the current experience (improving it ideally). As themes become more block-based, I imagine these screens will be deprecated (only used for older themes) because adding widgets/menus/blocks will happen in the full site editor. |
I understand the reasoning but I think that these new admin pages, even if they're in a way "temporary", need to have a consistent design. They will live in the admin for several months, maybe years before they're deprecated. I'd definitely vote to have a consistent design in the admin. There are already too many different admin pages layouts and this isn't beneficial for users under many aspects. |
I think this overview issue reached it's end. We're deep into implementing the proposed designs and each open topic above has gone through their own issue / iteration so far. Can reopen if needed. |
Revisiting the new Widget Editor, I can see a few areas that require design updates.
Widget areas
Currently, the widgets.php screen shows all theme-registered widget areas together. This is how the experimental Widget Editor works as well.
Overall improvements from widgets.php
Multiple widget areas vs. Single widget area
I'm exploring whether or not we should display all widget areas in one screen, or add a switcher that only allows one widget area to be visible at a time.
Multiple widget areas in screen
Remains closer to existing user expectations by presenting all widgets areas and blocks in the same screen.
PROS
CONS
Single widget area in screen
PROS
CONS
Single widget area + Inactive Widget Area
To remedy the CON in the single widget area exploration, there's a possibility of always showing an Inactive Widget Area. This area would always be visible from whatever main area was being edited.
PROS
CONS
Block Library
Similarly to the widgets.php screen, we can open the Block Library panel by default.
Widget area switcher
Moving toward a Single Widget Area, a switcher would be necessary to move users from one widget area to another.
Paragraph placeholder
Instead of showing a consistent "Add" button at the bottom of the widget area, we can make this more like the Block Editor by showing the Paragraph block's placeholder instead with the in-page Inserter
+
button.Document Inspector
When the Document Inspector is open in the Widget Editor, it should display the Widget Area's name and include the description provided by the theme.
The text was updated successfully, but these errors were encountered: