Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets screen: Can't tell which Legacy Widgets are on my screen without selecting them #24566

Closed
noisysocks opened this issue Aug 14, 2020 · 10 comments · Fixed by #25690
Closed
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@noisysocks
Copy link
Member

When I first open the new Widgets screen, I'm greeted with this:

Screen Shot 2020-08-14 at 15 16 07

Because we're hiding the title from the Legacy Widget block until it's selected, it's really hard to tell what widgets I have in my widget areas.

How about we always show the title?

Screen Shot 2020-08-14 at 15 13 03

@noisysocks noisysocks added Needs Design Feedback Needs general design feedback. [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Aug 14, 2020
@ZebulanStanphill ZebulanStanphill added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility labels Aug 28, 2020
@ZebulanStanphill
Copy link
Member

Since the legacy widgets here aren't acting as a front-end preview, I think we should definitely give them visible borders and text labels. I guess in general they should look more like the placeholders on various blocks (e.g. Image, Video, etc.), with solid backgrounds and a clear visual look that indicates "I'm a set of plain controls that isn't WYSIWYG at all".

@afercia
Copy link
Contributor

afercia commented Aug 31, 2020

Also, as reported in another issue, all the widgets should be listed with a H3 heading in the same way it happens now in the legacy Widgets screen.

@mapk
Copy link
Contributor

mapk commented Sep 9, 2020

Good points here. @noisysocks, I agree when there's tons of forms from various widgets, it's important to communicate which widget they apply to and group them somehow so they don't bleed into other widget forms visually.

I see this working is like this:

Unselected (resting) - requiring input to work
When a Legacy widget block is unselected (resting) but requires necessary form inputs to work, it should show the "Edit" view.

unselected requiring input

Unselected (resting) - not requiring input to work
When the Legacy widget block is unselected and does not require any input to show properly, it should default to the "Preview" view.

unselected not requiring input

Selected (focused)
Any Legacy widget block that has focus automatically defaults to the "Edit" view unless changed manually to the "Preview" view, but if unselected and selected again, it defaults again to the "Edit" view.

selected

@ZebulanStanphill
Copy link
Member

@mapk Nice mockups. That looks a lot better than the current situation.

@afercia
Copy link
Contributor

afercia commented Sep 10, 2020

I agree when there's tons of forms from various widgets, it's important to communicate which widget they apply to and group them somehow so they don't bleed into other widget forms visually.

I'd totally second this. And it needs to be communicated also semantically, not only visually. So that assistive technologies can understand the grouping and communicate it to users.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Sep 11, 2020
@mapk
Copy link
Contributor

mapk commented Sep 11, 2020

Looks like we've got some good direction here. 🎉 Thanks, everyone!

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 25, 2020
@adamziel
Copy link
Contributor

Merging #25638 marked a first step towards this. For now, all legacy widgets default to forms with a visible title bar. The next step would be detecting which widgets require user input to generate preview, and defaulting to preview for these.

@afercia
Copy link
Contributor

afercia commented Sep 28, 2020

Glad to see the progress made on #25638. Question: why the widget titles aren't H3 headings as asked for in this issue and in #24561? A good headings hierarchy is fundamental not only for better semantics but also as a navigational tool for assistive technology users.

@adamziel
Copy link
Contributor

Good point @afercia - let's definitely make them H3 headings

@kevin940726
Copy link
Member

Accidentally closed this via #25690, reopen it now.

@kevin940726 kevin940726 reopened this Sep 29, 2020
@kevin940726 kevin940726 removed their assignment Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants