Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every block should have help text #2023

Closed
jasmussen opened this issue Jul 26, 2017 · 4 comments
Closed

Every block should have help text #2023

jasmussen opened this issue Jul 26, 2017 · 4 comments
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks
Milestone

Comments

@jasmussen
Copy link
Contributor

Inspire by discussion in #1343 (comment) and related to #1924 (comment), now that we have a split "Settings" sidebar with sticky Document and Block tabs, we should ensure that information is shown in the "Blocks" inspector for every single block you select.

If no description or inspector is provided by a block, we should show some text there, such as "This block has no description."

@jasmussen jasmussen added [Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks labels Jul 26, 2017
@octalmage
Copy link
Contributor

Here's one I wrote to take the date format specified in WordPress and use it to format dates client side. We've used it in a production application for a while now.

https://github.com/octalmage/phptomoment

@karmatosed karmatosed self-assigned this Sep 25, 2017
@karmatosed karmatosed added this to the Beta 1.3 milestone Sep 25, 2017
@aduth
Copy link
Member

aduth commented Sep 27, 2017

If no description or inspector is provided by a block, we should show some text there, such as "This block has no description."

We should consider creating a separate issue for this from merely adding descriptions for more blocks (assuming I understand the intent of this pull request). This is also related to some previous discussion #1100 and effort at #1343.

@jasmussen
Copy link
Contributor Author

Noting that I have a PR that needs a massive rebase here: #2427 — it virtually addresses this, though. Will look at getting this ship shape today.

@jasmussen
Copy link
Contributor Author

Closing as fixed per the merging of #2427. Additionally I have opened separate tickets for the remaining blocks:

#2831
#2832
#2833

ceyhun pushed a commit that referenced this issue Apr 22, 2020
…it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS
ceyhun pushed a commit that referenced this issue Apr 22, 2020
* Release v1.26.0 (#2153)

* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Pinar Olguc <[email protected]>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <[email protected]>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: jbinda <[email protected]>
Co-authored-by: Chip <[email protected]>
Co-authored-by: Maxime Biais <[email protected]>
Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Klymentiy Haykov <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>

* Update gb ref

Co-authored-by: Chip Snyder <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: jbinda <[email protected]>
Co-authored-by: Chip <[email protected]>
Co-authored-by: Maxime Biais <[email protected]>
Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Klymentiy Haykov <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>
Tug added a commit that referenced this issue May 12, 2020
* Add tests for Latest-Posts Bock

* Have the Automation tests Scroll the Block window to help locate Block buttons on Android

* Update gutenberg reference

* Update Gutenberg ref

* Update Gutenberg ref

* New template for release PRs

This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs.

This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md`

* Update template file.

* Fix: remove extra padding for post title and first `Paragraph` block (#2095)

* Fix: remove extra padding for post title and first `Paragraph` block

* Update Gutenberg ref

* Add a new androidReplacements function to comply with Android Typography lint rules

* Make sure the file gutenberg.pot exists before generating android and ios strings.

* Update Gutenberg ref

* Update gutenberg ref

* Update gutenberg ref

* Update gutenberg reference

* Gutenberg update

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023)

* prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS

* Update Gutenberg ref

* Update Gutenberg ref

* Accept multiple headers through OnAuthHeaderRequestedListener (#2080)

* Blog layout template (#2114)

* Update Gutenberg ref

* Update Gutenberg ref

* Update gutenberg reference

* Fix failing UI tests

Try scrolling in the Inserter for all platforms

* Disable the failing test on iOS

Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Pinar Olguc <[email protected]>

* Update gutenberg reference

* Feat: Column block (#1661)

* update ref to master (Columns Block)

* Update gutenberg reference

* Fix Latests Posts Tests by expanding the scroll to button functionality

* Fix lint issue

* Fix typography breakage in master

To a version where the typography panel is not added to block settings.

* Update GB reference.

* Correct slider step value (#2119)

* Update ref: Correct slider step accordingly to the platform

* Update gb ref

Co-authored-by: Pinar Olguc <[email protected]>

* v1.26.0

* Add some missing release notes

* Update Podfile.lock

* Update gb ref

* Update bundles

Co-authored-by: Chip Snyder <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Sérgio Estêvão <[email protected]>
Co-authored-by: jbinda <[email protected]>
Co-authored-by: Chip <[email protected]>
Co-authored-by: Maxime Biais <[email protected]>
Co-authored-by: Tugdual de Kerviler <[email protected]>
Co-authored-by: Klymentiy Haykov <[email protected]>
Co-authored-by: Matthew Kevins <[email protected]>
Co-authored-by: Luke Walczak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

No branches or pull requests

4 participants