Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show block description for gallery block for 0 images #2924

Merged
merged 2 commits into from
Oct 9, 2017

Conversation

StuartFeldt
Copy link
Contributor

@StuartFeldt StuartFeldt commented Oct 8, 2017

Description

Gallery block is updated to show block description regardless of how many images are selected. Relates to #2023

How Has This Been Tested?

Manually tested, ran all test suites

Types of changes

UX updates

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@codecov
Copy link

codecov bot commented Oct 8, 2017

Codecov Report

Merging #2924 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2924      +/-   ##
==========================================
- Coverage   34.07%   34.06%   -0.02%     
==========================================
  Files         192      192              
  Lines        5675     5677       +2     
  Branches      996      997       +1     
==========================================
  Hits         1934     1934              
- Misses       3165     3166       +1     
- Partials      576      577       +1
Impacted Files Coverage Δ
blocks/library/gallery/block.js 11.11% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cd1f5...0262c7a. Read the comment docs.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@youknowriad youknowriad merged commit 87cfefb into WordPress:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants