Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block description/help text to Classic Text #2832

Closed
jasmussen opened this issue Sep 29, 2017 · 0 comments · Fixed by #2919
Closed

Add block description/help text to Classic Text #2832

jasmussen opened this issue Sep 29, 2017 · 0 comments · Fixed by #2919
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Developer Documentation Documentation for developers

Comments

@jasmussen
Copy link
Contributor

All blocks should have descriptions (see #2023). The Classic Text block is missing one.
@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks [Type] Developer Documentation Documentation for developers Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Sep 29, 2017
@jasmussen jasmussen mentioned this issue Sep 29, 2017
Closed
DevinWalker added a commit to DevinWalker/gutenberg that referenced this issue Oct 8, 2017
@DevinWalker
Removed unncessary line break WordPress#2832
3ffe188
DevinWalker added a commit to DevinWalker/gutenberg that referenced this issue Oct 8, 2017
@DevinWalker
Added a description for the "Classic" editor WordPress#2832
cb1d7a9
@DevinWalker DevinWalker mentioned this issue Oct 8, 2017
Merged
3 tasks
DevinWalker added a commit to DevinWalker/gutenberg that referenced this issue Oct 10, 2017
@DevinWalker
1. removed variable usage as suggested by @aduth
ec7f1a9 
2. Updated description WordPress#2832
aduth pushed a commit that referenced this issue Oct 12, 2017
@aduth
Added a description for the "Classic" editor #2832 (#2919)
3163539 
* Added a description for the "Classic" editor #2832

* Removed undefined "focus" - resolves broken unit test

* 1. removed variable usage as suggested by @aduth
2. Updated description #2832

* Adjusted description of classic text block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a description for the "Classic" editor #2832 DevinWalker/gutenberg
1 participant
@jasmussen