feat(/welcome): add messages for new intents and results #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
raducristianpopa marked as non substantive for IPR from ash-nazg. |
| } | ||
|
|
||
| type Intent = 'connect' | 'funds' | ||
| type Intent = 'connect' | 'reconnect' | 'funds' | 'update_budget' |
There was a problem hiding this comment.
We need to add messages for reconnect and update_budget as well.
There was a problem hiding this comment.
added messages for update_budget intent.
for the reconnect intent we don't need messages as we reuse the grant we have (we do not ask to accept/reject grant), KEY_SUCCESS and KEY_ERROR act as messages for reconnect
sidvishnoi
changed the title
sidvishnoi
approved these changes
Dec 5, 2024
raducristianpopa
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #481
Closes interledger/web-monetization-extension#738