Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ErrorKeyRevoked): reconnect with automatic key addition #714

Merged
merged 19 commits into from
Dec 9, 2024
Merged

feat(ErrorKeyRevoked): reconnect with automatic key addition #714

merged 19 commits into from
Dec 9, 2024

Conversation

DarianM
Copy link
Member

@DarianM DarianM commented Nov 17, 2024 •
edited by sidvishnoi
Loading

Context

When the public key is revoked, instead of manually asking to copy/pasta the key to reconnect the wallet, use KeyAutoAddService to automatically add the key back,

Closes #653 .

EDIT: depends on #742 to be done

Changes proposed in this pull request

  • add publicKey to wallet automatically (with user's consent) then redirect to welcome page

@DarianM DarianM self-assigned this Nov 17, 2024
@DarianM DarianM linked an issue Nov 17, 2024 that may be closed by this pull request
Use automatic key addition when key revoked during use #653
Closed
@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup labels Nov 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 1b1f6e8
Latest job logs Run #12230800802
BadgeDownload
BadgeDownload

@DarianM DarianM marked this pull request as ready for review November 18, 2024 10:00
@DarianM DarianM requested a review from sidvishnoi November 18, 2024 10:00
raducristianpopa
raducristianpopa reviewed Nov 19, 2024
View reviewed changes
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/popup/components/ErrorKeyRevoked.tsx Outdated Show resolved Hide resolved
@DarianM DarianM marked this pull request as draft November 21, 2024 11:42
sidvishnoi
sidvishnoi reviewed Nov 21, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/popup/components/ErrorKeyRevoked.tsx Outdated Show resolved Hide resolved
src/popup/components/ErrorKeyRevoked.tsx Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
@DarianM DarianM requested a review from sidvishnoi November 25, 2024 01:17
@DarianM DarianM marked this pull request as ready for review November 25, 2024 09:32
sidvishnoi
sidvishnoi reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there...

src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/popup/components/AutoKeyAddConsent.tsx Outdated Show resolved Hide resolved
src/popup/components/AutoKeyAddConsent.tsx Outdated Show resolved Hide resolved
src/popup/components/ErrorKeyRevoked.tsx Outdated Show resolved Hide resolved
@DarianM DarianM requested a review from sidvishnoi November 25, 2024 15:04
DarianM
DarianM commented Nov 25, 2024
View reviewed changes
src/_locales/en/messages.json
@@ -168,6 +168,9 @@
"connectWalletKeyService_text_consentP1": {
"message": "We will automatically connect with your wallet provider."
},
"reconnectWalletKeyService_text_consentP1": {
"message": "We will automatically reconnect with your wallet provider."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: ask to improve message later

sidvishnoi
sidvishnoi approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉💯

@sidvishnoi sidvishnoi changed the title feat: reconnect auto key addition feat(ErrorKeyRevoked): reconnect with automatic key addition Nov 26, 2024
@raducristianpopa raducristianpopa mentioned this pull request Nov 27, 2024
Closed
1 task
@sidvishnoi sidvishnoi mentioned this pull request Nov 29, 2024
Closed
1 task
@DarianM
Copy link
Member Author

DarianM commented Dec 4, 2024

I would like to merge WICG/webmonetization/481 first,
to test the entire flow one last time

@github-actions github-actions bot added area: pages Changes to any of extension's pages area: shared Changes to shared libraries and utilities labels Dec 8, 2024
sidvishnoi
sidvishnoi approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a code style improvement, but LGTM 🎉

src/background/services/openPayments.ts Outdated Show resolved Hide resolved
@DarianM DarianM requested a review from sidvishnoi December 9, 2024 07:19
@sidvishnoi sidvishnoi merged commit f490581 into main Dec 9, 2024
9 checks passed
@sidvishnoi sidvishnoi deleted the reconnect-automatic-key-addition branch December 9, 2024 07:43
@sidvishnoi sidvishnoi mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

@sidvishnoi sidvishnoi sidvishnoi approved these changes

Assignees

@DarianM DarianM

Labels
area: background Improvements or additions to extension background script area: i18n area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup area: shared Changes to shared libraries and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use automatic key addition when key revoked during use
3 participants
@DarianM @sidvishnoi @raducristianpopa