Introduce ObserverOptions for signal to live in
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
changed the title
ObserverOptions for signal to live in
|
There is no controversy around this and I've started implementing this in Chromium, so I'm going to land this PR. |
github-actions bot
added a commit
that referenced
this pull request
Nov 20, 2023
SHA: 1dc5463 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 21, 2023
This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. [email protected] Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 21, 2023
This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. [email protected] Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 21, 2023
This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. [email protected] Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1227666}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 21, 2023
This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. [email protected] Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1227666}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 26, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. [email protected] Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 27, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. [email protected] Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 27, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. [email protected] Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 28, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. [email protected] Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. R=masonfchromium.org Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <domchromium.org> Reviewed-by: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295 UltraBlame original commit: 4e0693e5004ddbf96ffd35d00ffd72526b384f90
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. R=masonfchromium.org Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <domchromium.org> Reviewed-by: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295 UltraBlame original commit: 2bc91571ae99012866b0f18f48e4df9a89dc75cf
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. R=masonfchromium.org Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <domchromium.org> Reviewed-by: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295 UltraBlame original commit: 4e0693e5004ddbf96ffd35d00ffd72526b384f90
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. R=masonfchromium.org Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <domchromium.org> Reviewed-by: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295 UltraBlame original commit: 2bc91571ae99012866b0f18f48e4df9a89dc75cf
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. R=masonfchromium.org Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <domchromium.org> Reviewed-by: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295 UltraBlame original commit: 4e0693e5004ddbf96ffd35d00ffd72526b384f90
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2023
…rvable API, a=testonly Automatic update from web-platform-tests DOM: Introduce SubscribeOptions for Observable API This PR separates the AbortSignal from the callbacks passed into `subscribe()` via the `Observer` dictionary, into its own dictionary, where future options may live. This is a particularly useful ergonomic change for chaining Observables together. See WICG/observable#85 and WICG/observable#71 for any relevant design discussion. R=masonfchromium.org Bug: 1485981 Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377 Commit-Queue: Dominic Farolino <domchromium.org> Reviewed-by: Mason Freed <masonfchromium.org> Cr-Commit-Position: refs/heads/main{#1227666} -- wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76 wpt-pr: 43295 UltraBlame original commit: 2bc91571ae99012866b0f18f48e4df9a89dc75cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #84.