Skip to content

Commit

Permalink
Bug 1865927 [wpt PR 43295] - DOM: Introduce SubscribeOptions for Obse…
Browse files Browse the repository at this point in the history
…rvable API, a=testonly

Automatic update from web-platform-tests
DOM: Introduce SubscribeOptions for Observable API

This PR separates the AbortSignal from the callbacks passed into
`subscribe()` via the `Observer` dictionary, into its own dictionary,
where future options may live. This is a particularly useful ergonomic
change for chaining Observables together.

See WICG/observable#85 and
WICG/observable#71 for any relevant design
discussion.

R=masonfchromium.org

Bug: 1485981
Change-Id: I9b9f9cf26cb8b7a71d2aab7811ad681386cbfd5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5046377
Commit-Queue: Dominic Farolino <domchromium.org>
Reviewed-by: Mason Freed <masonfchromium.org>
Cr-Commit-Position: refs/heads/main{#1227666}

--

wpt-commits: dbd13167a668830be3817fa612b2f00299d3cd76
wpt-pr: 43295

UltraBlame original commit: 2bc91571ae99012866b0f18f48e4df9a89dc75cf
  • Loading branch information
marco-c committed Nov 30, 2023
1 parent e76aad1 commit 77d1244
Showing 1 changed file with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1165,6 +1165,8 @@ source
subscribe
(
{
}
{
signal
:
AbortSignal
Expand Down Expand Up @@ -1255,6 +1257,8 @@ source
subscribe
(
{
}
{
signal
:
controller
Expand Down Expand Up @@ -3791,6 +3795,8 @@ complete
)
'
)
}
{
signal
:
ac
Expand Down Expand Up @@ -4058,6 +4064,8 @@ push
complete
'
)
}
{
signal
:
ac
Expand Down Expand Up @@ -4534,6 +4542,8 @@ source
subscribe
(
{
}
{
signal
:
ac
Expand Down Expand Up @@ -5487,6 +5497,8 @@ push
complete
'
)
}
{
signal
:
ac
Expand Down

0 comments on commit 77d1244

Please sign in to comment.