Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(popup and tooltip): change corner to placement #589

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

rinaok
Copy link
Contributor

@rinaok rinaok commented Aug 2, 2022

@rinaok rinaok self-assigned this Aug 2, 2022
@rinaok rinaok changed the title chore(popup): change corner to placement refactor(popup): change corner to placement Aug 2, 2022
@rinaok rinaok added Type: Refactor ♻️ a code change that neither fixes a bug nor adds a feature and removed Type: Chore labels Aug 2, 2022
@rinaok rinaok added this to the Q.3 22 🕛 milestone Aug 2, 2022
@rinaok rinaok linked an issue Aug 2, 2022 that may be closed by this pull request
@rinaok rinaok requested review from YonatanKra and yinonov and removed request for YonatanKra August 2, 2022 09:12
@rinaok rinaok changed the title refactor(popup): change corner to placement refactor(popup and tooltip): change corner to placement Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #589 (6850af7) into main (289e07b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #589    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           71       113    +42     
  Lines          824      1417   +593     
  Branches        56        98    +42     
==========================================
+ Hits           824      1417   +593     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/components/src/lib/badge/badge.template.ts 100.00% <ø> (ø)
libs/components/src/lib/banner/banner.template.ts 100.00% <ø> (ø)
libs/components/src/lib/calendar/index.ts 100.00% <ø> (ø)
...components/src/lib/elevation/elevation.template.ts 100.00% <ø> (ø)
libs/components/src/lib/layout/layout.ts 100.00% <ø> (ø)
libs/components/src/lib/progress-ring/index.ts 100.00% <ø> (ø)
libs/components/src/lib/progress/progress.ts 100.00% <ø> (ø)
.../src/lib/accordion-item/accordion-item.template.ts 100.00% <100.00%> (ø)
...omponents/src/lib/accordion-item/accordion-item.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion-item/index.ts 100.00% <100.00%> (ø)
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rinaok rinaok merged commit 152d52f into main Aug 2, 2022
@rinaok rinaok deleted the change-corner-to-placement branch August 2, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor ♻️ a code change that neither fixes a bug nor adds a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consolidate position terminology
2 participants