-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate position terminology #510
Comments
Floating-ui calls it Placement instead of Corner. https://floating-ui.com/docs/computePosition#placement |
placement is an option. |
Regarding the Side-Drawer, we have icon-trailing so I think that the name you suggested (trailing) can be a good fit. |
Position reminds me of the position property (static, relative, fixed, absolute or sticky). Idk if it's a good name for this purpose. |
has not progressed lately but might help with guidance |
I foresee a similar debate starting here microsoft/fast#6185 (comment) |
@YonatanKra At the beginning, it was Placement. vwc-menu and vwc-dropdown have Corner, and we wanted consistency. It might be better to change it to Placement in all components. |
@rinaok |
@YonatanKra it was discussed in vivid-2 while working on tooltip. I also think that placement is better than corner |
I'm also in for placement :) |
@yinonov What do you think? Should we change "corner" to 'placement"? |
Agree 👍 |
Our goal is to consolidate the terminology used to describe the position of an element anchored to another.
popup features the corner terminology -
https://github.com/Vonage/vivid-3/tree/main/libs/components/src/lib/popup#corner
The Microsoft explainer introduces a concept of "position-set" in the context of declaring preferred anchored position, with fallbacks.
This might still be early in the process of being standardized, and it's not clear if it will be implemented in the future. it also seems to be a bit of a misnomer, as it's not a set of positions, but a set of fallbacks.
Vivid popup doesn't support such complex positioning.
Side drawer might deviate from the complexity presented here as it only allows 2 options; left and right (or start and end). A boolean member might be enough for its purpose.
The text was updated successfully, but these errors were encountered: