Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --longRunning option to link incrementally in a long living process #64

Merged
merged 1 commit into from
May 22, 2024

Conversation

lolgab
Copy link

@lolgab lolgab commented May 21, 2024

This works via a stdin-stdout protocol
the program works like this:

  1. it performs one linking
  2. prints SCALA_JS_LINKING_DONE\n to stdin
  3. waits until a \n is printed to stdin
  4. goes to 1.

This allows the Scala.js toolchain to perform incremental linking and be much faster to execute

This works via a `stdin`-`stdout` protocol
the program works like this:
1.  it performs one linking
2. prints `SCALA_JS_LINKING_DONE\n` to stdin
3. waits until a `\n` is printed to `stdin`
4. goes to 1.

This allows the Scala.js toolchain to perform incremental linking and be much faster to execute
Copy link

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit 05c15ae into VirtusLab:main May 22, 2024
7 checks passed
@lolgab lolgab deleted the incremental-linking-mode branch May 22, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants