Incremental Scala.js Linking #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/VirtusLab/scala-js-cli/releases/tag/v1.16.0.1 |
|
Should rebase after #2929 gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Scala.js has a powerful incremental linker which makes linking very fast for multiple links in a row.
The current way to linking, which spawns a new process every time scala-cli links, doesn't use its capability.
Changes
This changes scala-cli to launch a
scala-js-cliprocess with the newly added--longRunningmode.Then it tries to reuse it, if input did not change, otherwise it kills the process and starts a new one.
fullOptdoesn't use the--longRunningmode since it doesn't need to be done incrementally and so we can maintain the incremental compilation cache.Dependencies
--longRunningoption to link incrementally in a long living process scala-js-cli#64Comparison
Before
before.mov
After
after.mov