Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding progress bars and progress details for clients #104

Merged
merged 19 commits into from
Nov 1, 2024
Merged

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Oct 11, 2024

PR Type

Feature

Short Description

Clickup Ticket(s): https://app.clickup.com/t/868a6rfz2

  • Changing current progress bar to make it more flexible to be used by different compoents
  • Adding progress bars to each one of the clients

The progress details is going to look a bit broken until we update to FL4Health's next version which will include proper end times for fit and evaluate, which are missing right now.

Tests Added

Fully unit tested

Screenshot 2024-10-10 at 14 51 43
Screenshot 2024-10-10 at 14 51 57

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 99.34641% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.69%. Comparing base (9199bfb) to head (5ec639d).

Files with missing lines Patch % Lines
florist/app/jobs/details/page.tsx 99.34% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   93.94%   89.69%   -4.26%     
==========================================
  Files          23       23              
  Lines        1981     2066      +85     
  Branches      105      119      +14     
==========================================
- Hits         1861     1853       -8     
- Misses        120      213      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I thought I already approved this! LGTM!

@lotif lotif merged commit ee51217 into main Nov 1, 2024
5 checks passed
@lotif lotif deleted the client-progress branch November 1, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants