Upgrade fl4heath and made appropriate changes #110
Conversation
| from flwr.server import ServerConfig | ||
|
|
||
|
|
||
| DEFAULT_FORMATTER = logging.Formatter("%(levelname)s %(name)s %(asctime)s | %(filename)s:%(lineno)d | %(message)s") |
There was a problem hiding this comment.
I guess flwr removed the DEFAULT_FORMATTER they were exporting previously.
Here there reference it in the documentation so I just sourced it from there: https://flower.ai/docs/framework/how-to-configure-logging.html
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 23 23
Lines 2087 2107 +20
Branches 177 119 -58
=======================================
+ Hits 1966 1985 +19
- Misses 121 122 +1 ☔ View full report in Codecov by Sentry. |
Updated key name from type to host_type in tests and entities
| @@ -60,7 +62,6 @@ def start_server( | |||
| config=ServerConfig(num_rounds=n_server_rounds), | |||
| ) | |||
| server.shutdown() | |||
| server.metrics_reporter.dump() | |||
There was a problem hiding this comment.
Since we are dumping on every call to report I figured we can remove these?
There was a problem hiding this comment.
I guess, yes... I put it there just in case, it doesn't hurt, but I guess it's better to remove if it's not really necessary :)
Should be good to go @lotif! Let me know if there are any issues. |
PR Type
[Feature | Fix | Documentation | Other ]
Short Description
Clickup Ticket(s): Upgrade FL4Health Version
The current version depends on fl4health = "^0.1.15". fl4health 0.2.1 was just released. Since then a few things have changed, mostly in regards to reporter functionality, dependencies and utilities being shuffled around. Marcelo also needs the upgraded FL4Health for #104.
Most of the diff is stems from the poetry.lock. Otherwise, just some slight modifications had to be made to account for the new reporter and other small changes.
Tests Added
...