Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vicious Mockery Changes #588

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SarmentiCampbell
Copy link

@SarmentiCampbell SarmentiCampbell commented Jan 25, 2025

About The Pull Request

new lines for half orc and rakshari are required.

So basically, I've made it so vicious mockery can have the player input when out of combat, when in combat, it'll use a random lines like before.
The invocations lines were turned into a json files and will check for the species id to ensure it'll use the race's insults
It'll also won't say anything when you miss the target. (that was stupid tbh

Why It's Good For The Game

finally, i can call someone something and not have to continue it with a random insult.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@SarmentiCampbell SarmentiCampbell marked this pull request as draft January 25, 2025 17:46
meh
@SarmentiCampbell SarmentiCampbell marked this pull request as ready for review January 25, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant