Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch map improvements #121

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Patch map improvements #121

merged 4 commits into from
Dec 20, 2024

Conversation

mitchthorson
Copy link
Contributor

What's in this pull request

  • Bug fix
  • New component/feature
  • Component update
  • Documentation update
  • Other

Description

  • Fix: Color scale resets ticks when switching from threshold scale to continuous scale
  • Patch: SVGPolygonLayer uses mousedown instead of click event

Before submitting, please check that you've

  • Formatted your code correctly (i.e., prettier cleaned it up)
  • Documented any new components or features
  • Added any changes in this PR to the CHANGELOG.md Next section
  • If this pull request includes a new component or feature, has it been exported from one of the library's entry points?
  • Does the component dispatch relevant interaction events? (ie: on:click, on:change, etc.)
  • Does the component directory include description and usage information in .stories.svelte?

@mitchthorson mitchthorson marked this pull request as ready for review December 20, 2024 14:05
@mitchthorson mitchthorson merged commit 7c0e065 into main Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkates benkates benkates approved these changes

@rachelmarconi rachelmarconi Awaiting requested review from rachelmarconi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchthorson @benkates