Merge pull request #121 from UrbanInstitute/patch-map-improvements

Patch map improvements

.github/workflows/storybook-tests.yml

@@ -1,14 +1,14 @@
-name: 'Storybook Tests'
+name: "Storybook Tests"
 on: push
 jobs:
   test:
     timeout-minutes: 60
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: '20.x'
+          node-version: "20.x"
       - name: Install dependencies
         run: npm ci
       - name: Run Vitest tests

CHANGELOG.md

@@ -1,6 +1,8 @@
 # @UrbanInstitute/dataviz-components Changelog
 
 ## Next
+- Fix: Color scale resets ticks when switching from threshold scale to continuous scale
+- Patch: SVGPolygonLayer uses mousedown instead of click event
 
 ## v0.12.1
 - Fix: Add more specificity to several <p> tags to avoid CSS conflicts between <Theme /> and component styles

src/lib/maps/ColorLegend/ColorLegend.svelte

@@ -190,6 +190,8 @@
       : scale.quantiles
         ? scale.quantiles() // scaleQuantile
         : scale.domain(); // scaleThreshold
+  } else {
+    thresholds = undefined;
   }
 
   $: tickFormatFn = getTickFormatFn(tickFormat, thresholds);

src/lib/maps/SVGPolygonLayer/SVGPolygonLayer.svelte

@@ -163,7 +163,7 @@
       stroke-width={strokeWidth / $transform.k}
       d={geoPathFn(feature)}
       on:mousemove={(e) => handleMousemove(e, feature)}
-      on:click={(e) => handleClick(e, feature)}
+      on:mousedown={(e) => handleClick(e, feature)}
     ></path>
   {/each}
 </g>