Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispyfy DeviceHistoryViewFilter form in devicehistory #3041

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Sep 26, 2024

Closes #3003

Depends on #3034, #3048, #3047

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (2dae9d3) to head (27fb2e2).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
+ Coverage   60.44%   60.47%   +0.02%     
==========================================
  Files         605      605              
  Lines       43828    43827       -1     
  Branches       48       48              
==========================================
+ Hits        26494    26504      +10     
+ Misses      17322    17311      -11     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk force-pushed the uncrispyfy-device-history-view-filter-form branch from 8cbf2ce to 27fb2e2 Compare September 30, 2024 10:11
Copy link

sonarcloud bot commented Sep 30, 2024

@podliashanyk podliashanyk marked this pull request as ready for review September 30, 2024 10:17
@podliashanyk podliashanyk requested a review from a team September 30, 2024 10:17
Copy link
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as in #3039 about the CSRF-token. Otherwise all nice

@podliashanyk
Copy link
Contributor Author

Same comment here as in #3039 about the CSRF-token. Otherwise all nice

Created #3055

@podliashanyk podliashanyk merged commit 6c83dcf into Uninett:master Oct 1, 2024
12 of 13 checks passed
@podliashanyk podliashanyk deleted the uncrispyfy-device-history-view-filter-form branch October 1, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispify nav.web.devicehistory.forms.DeviceHistoryViewFilter
2 participants