Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispyfy StatusPanelForm in status2 #3042

Merged

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Sep 26, 2024

Closes #3037

Depends on #3034, #3048, #3047

Waiting until #3036 is merged with its form_id implementation.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (c24b90a) to head (1d963e2).
Report is 23 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3042   +/-   ##
=======================================
  Coverage   60.46%   60.47%           
=======================================
  Files         605      605           
  Lines       43801    43812   +11     
  Branches       48       48           
=======================================
+ Hits        26483    26494   +11     
  Misses      17306    17306           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk force-pushed the uncrispyfy-status-panel-form branch 3 times, most recently from a28c1bf to 1018fd7 Compare September 30, 2024 10:58
Copy link

sonarcloud bot commented Oct 3, 2024

@podliashanyk podliashanyk requested a review from a team October 3, 2024 12:13
@podliashanyk podliashanyk marked this pull request as ready for review October 3, 2024 12:13
{% else %}
{{ form }}
{% endif %}
<hr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only difference here is that the <hr> is not within the form, but visually the outcome is the same, so I would not care

@podliashanyk podliashanyk merged commit 86276ac into Uninett:master Oct 4, 2024
12 of 13 checks passed
@podliashanyk podliashanyk deleted the uncrispyfy-status-panel-form branch October 4, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispyfy nav.web.status2.forms.StatusPanelForm
2 participants