Remove unused dependencies #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 231 231
Lines 17800 17800
=======================================
Hits 17492 17492
Misses 308 308 ☔ View full report in Codecov by Sentry. |
This should be handled by dependabot.
|
@jmcarson when you get a chance, can you also check that these dependencies are not actually needed? |
Accept all incoming changes to requirements.txt files to get updated versions. Then recompile requirements files to remove unused packages.
|
Looks like removing argon2-cffi broke admin logins. oops. I'll add it back in in a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove packages that are not actually being used. This will cut down on dependabot noise.