Clean up test coverage

primed/dbgap/tests/test_audit.py

@@ -1420,3 +1420,10 @@ def test_queryset(self):
         self.assertEqual(record.user, dbgap_application_2.principal_investigator)
         self.assertEqual(record.member, None)
         self.assertEqual(record.note, collaborator_audit.dbGaPCollaboratorAudit.PI_NO_ACCOUNT)
+
+    def test_queryset_wrong_class(self):
+        """Raises ValueError if queryset is not a QuerySet."""
+        with self.assertRaises(ValueError):
+            collaborator_audit.dbGaPCollaboratorAudit(queryset="foo")
+        with self.assertRaises(ValueError):
+            collaborator_audit.dbGaPCollaboratorAudit(queryset=models.dbGaPStudyAccession.objects.all())

primed/primed_anvil/tables.py

@@ -1,5 +1,5 @@
 import django_tables2 as tables
-from anvil_consortium_manager.models import Account, Workspace
+from anvil_consortium_manager.models import Account, ManagedGroup, Workspace
 from django.contrib.auth import get_user_model
 from django.core.exceptions import ImproperlyConfigured
 from django.utils.html import format_html
@@ -174,6 +174,8 @@ class Meta:
     def __init__(self, *args, managed_group=None, **kwargs):
         if managed_group is None:
             raise ValueError("managed_group must be provided.")
+        if not isinstance(managed_group, ManagedGroup):
+            raise ValueError("managed_group must be an instance of ManagedGroup.")
         self.managed_group = managed_group
         super().__init__(*args, **kwargs)
 

primed/primed_anvil/tests/test_tables.py

@@ -306,3 +306,13 @@ def test_ordering(self):
         table = tables.UserAccountSingleGroupMembershipTable(User.objects.all(), managed_group=self.managed_group)
         self.assertEqual(table.data[0], user_bar)
         self.assertEqual(table.data[1], user_foo)
+
+    def test_managed_group_not_provided(self):
+        with self.assertRaises(ValueError) as e:
+            tables.UserAccountSingleGroupMembershipTable(User.objects.all())
+        self.assertEqual(str(e.exception), "managed_group must be provided.")
+
+    def test_managed_group_wrong_class(self):
+        with self.assertRaises(ValueError) as e:
+            tables.UserAccountSingleGroupMembershipTable(User.objects.all(), managed_group=AccountFactory.create())
+        self.assertEqual(str(e.exception), "managed_group must be an instance of ManagedGroup.")