Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mattbranch #28

Open
wants to merge 35 commits into
base: devel
Choose a base branch
from
Open

Mattbranch #28

wants to merge 35 commits into from

Conversation

mconomos
Copy link
Contributor

@mconomos mconomos commented Apr 9, 2020

I added the option to include a locus name in the title of the plot and the filename. This is done by including an optional locus_name column in the locus_file. It seems to work, but one issue with this is that the title can get too long and run off the figure - any ideas on how to address this? (I actually think this was already occasionally an issue).

I also made the significance line a modifiable parameter by adding a signif_level parameter to the config file.

@mconomos
Copy link
Contributor Author

mconomos commented Apr 30, 2020

@smgogarten I've made a lot of commits, so I wanted to sum up what I've changed in the locuszoom plots:

  • Made the significance threshold modifiable
  • Made it possible to have the plot label the variant with the rsID (rather than chr:pos) by including an "rsid" column in the locus_file
  • Made it possible to include a locus name in both the file name and figure title by including a "locus_name" column in the locus_file
  • Separated out the code that puts together the figure title; rearranged it a bit
  • Made the figure title optional by adding a parameter "title" to the config file that defaults to TRUE
  • Made the number of rows allocated for genes at the bottom of the figure modifiable by adding a parameter "gene_rows" to the config file. The locuszoom default is 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant