Try out new gulp task for USWDS assets #698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jan 15, 2025
dzole0311
added a commit
to NASA-IMPACT/veda-ui
that referenced
this pull request
Jan 15, 2025
**Related Ticket:** closes #1373 ### Description of Changes The gulp task for copying the USWDS assets during deployment was not copying the assets at all. I've updated the task by replacing the generic `uswds.copyImages()` function with an explicit gulp task ### Notes & Questions About Changes - The change follows the same pattern as other copy tasks in our gulpfile - No other configuration changes are needed as the task is already used into the existing build process ### Validation / Testing - In the deploy preview for veda-ui and veda-config-ghg (PR with deployment: US-GHG-Center/veda-config-ghg#698), verify that USWDS icons appear correctly in the `SiteAlert` or `Banner` components - Check if the icons appear when running the veda-ui locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you creating this Pull Request?