Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the gulp task for copying USWDS assets #1378

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

dzole0311
Copy link
Collaborator

@dzole0311 dzole0311 commented Jan 15, 2025

Related Ticket: closes #1373

Description of Changes

The gulp task for copying the USWDS assets during deployment was not copying the assets at all. I've updated the task by replacing the generic uswds.copyImages() function with an explicit gulp task

Notes & Questions About Changes

  • The change follows the same pattern as other copy tasks in our gulpfile
  • No other configuration changes are needed as the task is already used into the existing build process

Validation / Testing

@dzole0311 dzole0311 added the veda v2 VEDA Refactor Epic Work label Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 890c6b5
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/67879cb95b20ac0008e3219c
😎 Deploy Preview https://deploy-preview-1378--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sandrahoang686 sandrahoang686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui and ghgh previews lgtm

@dzole0311 dzole0311 closed this Jan 15, 2025
@dzole0311 dzole0311 deleted the chore-update-uswds-gulp-task branch January 15, 2025 15:12
@dzole0311 dzole0311 restored the chore-update-uswds-gulp-task branch January 15, 2025 15:12
@dzole0311 dzole0311 reopened this Jan 15, 2025
@dzole0311 dzole0311 merged commit 21850ee into main Jan 15, 2025
18 checks passed
@dzole0311 dzole0311 deleted the chore-update-uswds-gulp-task branch January 15, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SiteAlert and Banner icons not shown in the GHG Center
2 participants