Skip to content

Commit

Permalink
fix: fix keep_default_na behaviour for read_csv (#93)
Browse files Browse the repository at this point in the history
* feat: removed keep_default_na from read_csv reader
  • Loading branch information
Sanix-Darker authored Mar 1, 2022
1 parent 8c71616 commit 9e28504
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions peakina/readers/csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ def read_csv(
preview_offset: int = 0,
preview_nrows: Optional[int] = None,
# change of default values
keep_default_na: bool = False, # pandas default: `True`
error_bad_lines: bool = False, # pandas default: `True`
**kwargs: Any,
) -> pd.DataFrame:
Expand All @@ -33,7 +32,6 @@ def read_csv(
if preview_nrows is not None or preview_offset:
chunks = pd.read_csv(
filepath_or_buffer,
keep_default_na=keep_default_na,
error_bad_lines=error_bad_lines,
**kwargs,
# keep the first row 0 (as the header) and then skip everything else up to row `preview_offset`
Expand All @@ -45,7 +43,6 @@ def read_csv(

return pd.read_csv(
filepath_or_buffer,
keep_default_na=keep_default_na,
error_bad_lines=error_bad_lines,
**kwargs,
)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "peakina"
version = "0.7.1"
version = "0.7.2"
description = "pandas readers on steroids (remote files, glob patterns, cache, etc.)"
authors = ["Toucan Toco <[email protected]>"]
readme = "README.md"
Expand Down

0 comments on commit 9e28504

Please sign in to comment.