Calendar Coffea processor and remove futures executor #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 17, 2024
Open
This was
unlinked from
issues
Feb 17, 2024
Open
This was
linked to
issues
Feb 17, 2024
Open
bryates
commented
Feb 17, 2024
| @@ -344,15 +345,15 @@ def process(self, events): | |||
| for syst_var in syst_var_list: | |||
| # Make a copy of the base weights object, so that each time through the loop we do not double count systs | |||
| # In this loop over systs that impact kinematics, we will add to the weights objects the SFs that depend on the object kinematics | |||
| weights_obj_base_for_kinematic_syst = copy.deepcopy(weights_obj_base) | |||
There was a problem hiding this comment.
Need to verify this didn't change the results.
This was
linked to
issues
Feb 19, 2024
lep SF `deepcopy` -> `copy` Turned off jet cleaning until dask indexing can be sorted out
Open
This was
unlinked from
issues
Mar 14, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes instances of
lenin the processor and theFuturesExecutorin favor ofdask.compute()