Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert flip rate coffea.hist to hist #397

Closed
bryates opened this issue Feb 17, 2024 · 0 comments · Fixed by #416
Closed

Convert flip rate coffea.hist to hist #397

bryates opened this issue Feb 17, 2024 · 0 comments · Fixed by #416
Assignees
@bryates @sscruz

Comments

@bryates
Copy link
Contributor

bryates commented Feb 17, 2024 •
edited
Loading

The pkl files containing the fake rates were made with coffea.hist. We need to convert them to hist.

    AttachPerLeptonFR(e_fo, flavor = "Elec", year=year)
  File "/afs/crc.nd.edu/user/b/byates2/coffea2023/topeft/topeft/modules/corrections.py", line 267, in AttachPerLeptonFR
    flip_hist = pickle.load(fin)
ModuleNotFoundError: No module named 'coffea.hist'
@bryates bryates linked a pull request Feb 19, 2024 that will close this issue
Calendar Coffea processor and remove futures executor #391
Open
@bryates bryates moved this from Ready to In progress in Calendar Coffea roadmap Feb 19, 2024
@bryates bryates removed a link to a pull request Mar 14, 2024
Calendar Coffea processor and remove futures executor #391
Open
@bryates bryates mentioned this issue May 21, 2024
Merged
@bryates bryates changed the title Convert fake rate coffea.hist to hist Convert flip rate coffea.hist to hist May 21, 2024
@bryates bryates linked a pull request May 22, 2024 that will close this issue
Converting coffea.hist files to hist #416
Merged
@bryates bryates moved this from In progress to In review in Calendar Coffea roadmap May 23, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Calendar Coffea roadmap May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryates bryates

@sscruz sscruz

Labels
None yet
Projects
Calendar Coffea roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Converting coffea.hist files to hist TopEFT/topeft
2 participants
@bryates @sscruz