Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Don't move trivially copyable values. #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup: Don't move trivially copyable values. #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/model/friendmessagedispatcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ FriendMessageDispatcher::FriendMessageDispatcher(Friend& f_, MessageProcessor pr
: f(f_)
, coreExtPacketAllocator(coreExtPacketAllocator_)
, messageSender(messageSender_)
, processor(std::move(processor_))
, processor(processor_)
{
connect(&f, &Friend::onlineOfflineChanged, this,
&FriendMessageDispatcher::onFriendOnlineOfflineChanged);
Expand Down
2 changes: 1 addition & 1 deletion src/platform/camera/v4l2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ QVector<VideoMode> v4l2::getDeviceModes(QString devName)
for (float rate : rates) {
mode.FPS = rate;
if (!modes.contains(mode)) {
modes.append(std::move(mode));
modes.append(mode);
}
}
vfse.index++;
Expand Down
6 changes: 2 additions & 4 deletions src/widget/widget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,8 +1167,7 @@ void Widget::addFriend(uint32_t friendId, const ToxPk& friendPk)

auto messageProcessor = MessageProcessor(*sharedMessageProcessorParams);
auto friendMessageDispatcher =
std::make_shared<FriendMessageDispatcher>(*newfriend, std::move(messageProcessor), *core,
*core->getExt());
std::make_shared<FriendMessageDispatcher>(*newfriend, messageProcessor, *core, *core->getExt());

// Note: We do not have to connect the message dispatcher signals since
// ChatHistory hooks them up in a very specific order
Expand Down Expand Up @@ -2142,8 +2141,7 @@ Group* Widget::createGroup(uint32_t groupnumber, const GroupId& groupId)
auto widget = new GroupWidget(chatroom, compact, settings, style);
auto messageProcessor = MessageProcessor(*sharedMessageProcessorParams);
auto messageDispatcher =
std::make_shared<GroupMessageDispatcher>(*newgroup, std::move(messageProcessor), *core,
*core, settings);
std::make_shared<GroupMessageDispatcher>(*newgroup, messageProcessor, *core, *core, settings);

auto history = profile.getHistory();
// Note: We do not have to connect the message dispatcher signals since
Expand Down
Loading